Skip to content

Remove vec_cast.<datelike>.double() methods #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DavisVaughan opened this issue Jan 13, 2020 · 1 comment · Fixed by #965
Closed

Remove vec_cast.<datelike>.double() methods #741

DavisVaughan opened this issue Jan 13, 2020 · 1 comment · Fixed by #965
Milestone
0.3.0

Comments

@DavisVaughan
Copy link
Member

Part of 0.3.0, since it is breaking an existing cast method.

It was determined that casting dates/datetimes to and from integer/double is too relaxed here #728 (comment)

  • vec_cast.Date.double()
  • vec_cast.POSIXct.double()
  • vec_cast.POSIXlt.double()

Supersedes #728 and #715
@DavisVaughan DavisVaughan added this to the 0.3.0 milestone Jan 13, 2020
This was referenced Jan 13, 2020
Closed
Closed
@lionel-
Copy link
Member

lionel- commented Feb 12, 2020

Part of #606

lionel- added a commit to lionel-/vctrs that referenced this issue Mar 27, 2020
@lionel-
Restrict vec_cast() methods to common types
5f35c2b 
Closes r-lib#606
Closes r-lib#741
@lionel- lionel- mentioned this issue Mar 27, 2020
Merged
lionel- added a commit that referenced this issue Mar 28, 2020
@lionel-
Restrict vec_cast() methods to common types (#965)
67c49a1 
Closes #606
Closes #741
@davidchall davidchall mentioned this issue May 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.0
Development

Successfully merging a pull request may close this issue.

Restrict vec_cast() methods to common types lionel-/vctrs
2 participants
@lionel- @DavisVaughan