Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recursive and use.names arguments to c.vctrs_vctr()? #791

Closed
krlmlr opened this issue Feb 3, 2020 · 4 comments
Closed

Add recursive and use.names arguments to c.vctrs_vctr()? #791

krlmlr opened this issue Feb 3, 2020 · 4 comments

Comments

@krlmlr
Copy link
Member

krlmlr commented Feb 3, 2020

This might help users that are inadvertently using c(..., recursive = TRUE) . These arguments are part of the definition of the generic.

@krlmlr krlmlr changed the title Add recursive and use.names arguments to c()? Add recursive and use.names arguments to c.vctrs_vctr()? Feb 3, 2020
@lionel-
Copy link
Member

lionel- commented Feb 4, 2020

I don't think so?

@hadley
Copy link
Member

hadley commented Feb 10, 2020

It might be worthwhile just to avoid insidious errors? We'd throw an error if recursive or use.names were supplied, and only in c.vctrs_vctr, not in vec_c().

@lionel-
Copy link
Member

lionel- commented Feb 11, 2020

Ah yes, it makes sense to detect it in c methods.

@lionel-
Copy link
Member

lionel- commented Feb 11, 2020

(which I now see was your point @krlmlr, I read vec_c instead of c somehow)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants