Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control behavior of zeros in C level vec_as_location() #852

Closed
DavisVaughan opened this issue Feb 22, 2020 · 0 comments · Fixed by #854
Closed

Control behavior of zeros in C level vec_as_location() #852

DavisVaughan opened this issue Feb 22, 2020 · 0 comments · Fixed by #854
Assignees

Comments

@DavisVaughan
Copy link
Member

This would bubble up to R through num_as_location()

We need another option in vec_as_location_opts for controlling the behavior of zeros. I proposed this to @lionel- , who seemed to agree:

  • remove: The current behavior, removes zeros. Problematic in some cases because this changes the size of the index.
  • ignore: Leaves 0 values in place, unchanged.
  • error: Errors with a custom classed error for this case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant