nan is outside the range of representable values of type 'int' #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

lionel- opened this issue Mar 10, 2020 · 1 comment · Fixed by #914

Member

lionel- commented Mar 10, 2020

From clang-UBSAN: https://www.stats.ox.ac.uk/pub/bdr/memtests/clang-UBSAN/vctrs/tests/testthat.Rout

Somehow wasn't picked up by the r-hub sanitizers machine.

Member

DavisVaughan commented Mar 10, 2020

Need a if (isnan(elt)) {} check here

vctrs/src/subscript.c

Line 137 in 63b2712

int out_elt = (int) elt;

DavisVaughan mentioned this issue

Don't implicitly rely on nan -> NA_INTEGER cast #914

Merged

DavisVaughan closed this as completed in #914

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment