-
Notifications
You must be signed in to change notification settings - Fork 66
data.frame cast fallback #981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I like the idea, the warning will encourage people to normalise their inputs (we should link to a FAQ), and so their code won't be affected when the class authors end up implementing methods. Implementation will probably require a sentinel data frame class to avoid repeat warnings. |
Somehow it makes more sense for data frames than for other types. For example it wouldn't make sense to coerce factors to integers with a warning. Maybe the general rule is that if a class explicitly inherits from one of the base classes (including |
I think we may need a some data.frame fallbacks so that we get something like this:
(This is not a general regret that we're moving away from inheritance; it's a specific pragmatic fallback + warning for people working with multiple data frame subclasses)
The text was updated successfully, but these errors were encountered: