Soft-deprecate vec_equal_na() in favor of vec_detect_missing()
#1672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: - Exports `vec_any_missing()` - Writes a full help page for missing values - Cleans up equality help page
lionel-
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1586
Also exports
vec_any_missing()I've put
vec_any_missing()andvec_detect_missing()together on their own help page rather than grouping them withvec_equal(). Also gavevec_equal()help docs a refresh since I had to do surgery on them anyways.The R and C level renaming happened in the first commit. The actual doc changes and deprecation happened in the second commit, that should make it a little easier to review.