/vctrs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vec_c() and vec_rbind() to handle data.frame columns #182

Merged
merged 5 commits into from Feb 8, 2019

Conversation

Reviewers

@hadley hadley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@yutannihilation @hadley
@yutannihilation
Copy link
Contributor

yutannihilation commented Feb 7, 2019

Fix #178

  • df_length() should use vec_size() instead of length().
  • vec_rbind() should use vec_slice<-() to replace columns
@hadley

hadley approved these changes Feb 7, 2019
View changes

Copy link
Member

hadley left a comment

Looks good!

Can you please add a bullet to NEWS? It should briefly describe the change and end with (@yourname, #issuenumber).
@yutannihilation
Add a NEWS bullet
Loading status checks…
833ba63
@yutannihilation

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

yutannihilation commented Feb 7, 2019

Sorry, I forgot it. Added.

@hadley hadley merged commit 498acc9 into r-lib:master Feb 8, 2019
3 checks passed

3 checks passed

codecov/patch 100% of diff hit (target 98.11%)
Details
codecov/project 98.11% (+0%) compared to 0715639
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hadley

This comment has been minimized.

Sign in to view
Copy link
Member

hadley commented Feb 8, 2019

Thanks!

@yutannihilation yutannihilation deleted the yutannihilation:fix/remove-df-length branch Feb 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment