Adding difftime to date truncates the difftime to full dates #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, we need a warning here. |
hadley
reviewed
Feb 18, 2019
R/type-date-time.R
Outdated
| @@ -427,24 +427,34 @@ vec_arith.difftime.POSIXct <- function(op, x, y) { | |||
| #' @method vec_arith.Date difftime | |||
| #' @export | |||
| vec_arith.Date.difftime <- function(op, x, y) { | |||
| # Exit early to avoid warning | |||
| if (!(op %in% c("+", "-"))) { | |||
There was a problem hiding this comment.
I don't like moving this up front. Instead could we make a wrapper function, something like this:
round_warn <- function(x, to) {
x_floor <- floor(x)
report_lossy_cast(x, to, x != x_floor)
x_floor
}Then could call instead vec_arith_base()?
There was a problem hiding this comment.
Do you mind the fallthrough I've added?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
For full hms support. Do we need a lossy cast warning?