/ vctrs Public
vec_group_loc() vector access
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
This PR further optimizes
vec_group_loc(), which should directly result in performance improvements for
In Instruments I noticed that the biggest killer in
vec_group_loc()is the double deference in a tight loop of
INTEGER(VECTOR_ELT()). That can be replaced with an array of integer pointers that index directly into those integer vectors. That really helped.
Side note: It is insane how fast this is if you order the data ahead of time. As pointed out by @brodieG