Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add x_arg and value_arg to vec_assign() #918

merged 2 commits into from Mar 16, 2020


Copy link

@DavisVaughan DavisVaughan commented Mar 13, 2020

Closes #917

CC @krlmlr

Oh @lionel- I just had a thought. Should we add ... to the signature before x_arg and value_arg and check that they are empty? (I'm going to guess yes)

Copy link

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks!

Copy link

lionel- commented Mar 16, 2020

Merging now so I can resolve diff conflicts with my branch for #689 right away.

@lionel- lionel- merged commit f2f2a7a into r-lib:master Mar 16, 2020
@DavisVaughan DavisVaughan deleted the vec-assign-arg branch March 18, 2020 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Should vec_assign() have x_arg and value_arg?
3 participants