Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support gtable/grob object #36

Closed
thomasp85 opened this issue Aug 1, 2018 · 2 comments · Fixed by #37
Closed

Support gtable/grob object #36

thomasp85 opened this issue Aug 1, 2018 · 2 comments · Fixed by #37
Labels
feature

Comments

@thomasp85
Copy link
Member

It would be nice if vdiffr would support gtable (and potentially all grobs) natively in expect_doppelganger so that expressions that returned a gtable would get handled automatically. While I personally need it for visual testing in gganimate I guess it would also be beneficial to others relying on gtable manipulation for their functions
@lionel-
Copy link
Member

lionel- commented Aug 1, 2018

This makes sense. If you need it right away I'd welcome a PR. Only the github version of vdiffr is usable anyway, until freetypeharfbuzz gets reviewed by CRAN.

@thomasp85
Copy link
Member Author

I'll carve out some time for it

@Ryo-N7 Ryo-N7 mentioned this issue Dec 13, 2019
Closed
@lionel- lionel- mentioned this issue Jun 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add print_plot method for grob thomasp85/vdiffr
2 participants
@thomasp85 @lionel-