Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crash if file does not have a trailing newline #40

Closed
jimhester opened this issue Feb 22, 2019 · 5 comments

Comments

@jimhester
Copy link
Member

commented Feb 22, 2019

No description provided.

@jimhester jimhester added the bug label Feb 22, 2019

@jimhester

This comment has been minimized.

Copy link
Member Author

commented Feb 25, 2019

Fixed by 5f9c3b4

@jimhester jimhester closed this Feb 25, 2019

jimhester added a commit that referenced this issue Apr 19, 2019

Squashed 'src/mio/' changes from c7c7163a..88e0263b
88e0263b Fix memory mapped data offset
514837b2 Update test.cpp
18fbf199 Fix minor errors in internal docs
cafa3136 Merge pull request #40 from patrick--/single_header
3c655b70 Added single header file information to the README
647e9779 Initial single header support using amalgamate
3c658bf6 Merge pull request #38 from amallia/patch-1
d25c02f0 Update mmap.ipp
d35a6db8 Update mmap.ipp

git-subtree-dir: src/mio
git-subtree-split: 88e0263b075b832e78b9a36df58575a96ffe5e7d
@henry090

This comment has been minimized.

Copy link

commented May 11, 2019

This problem still exists, even in development version. @jimhester

Files must end with a newline
@jimhester

This comment has been minimized.

Copy link
Member Author

commented May 13, 2019

That is an error message, not a crash, for vroom to read them files must end in a newline. And actually by POSIX definition files must end with a newline to be a proper file.

I realize that Windows is not POSIX, but the way the vroom code works the file really does need to end with a newline.

@mgirlich

This comment has been minimized.

Copy link

commented May 21, 2019

what do about automatically (controlled via a parameter) adding a newline to the end of a file if it doesn't have one? Otherwise, I imagine many people using this workaround in their own code (I have a csv file from Excel that doesn't end in a newline so that might be quite a common problem...).

jimhester added a commit that referenced this issue Jun 6, 2019

@jimhester

This comment has been minimized.

Copy link
Member Author

commented Jun 6, 2019

vroom now has a workaround using a file connection to allow users to read files with no trailing newline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.