Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working in Windows (indefinitely hangs)? #98

Closed
sysilviakim opened this issue May 7, 2019 · 13 comments

Comments

@sysilviakim
Copy link

commented May 7, 2019

Hi,

I've been looking forward to the CRAN release, and I've so far used it only on a unix server, but when I tried running things in Windows, it does not work and it indefinitely hangs.

It is as simple as

install.packages("vroom")
vroom::vroom(vroom::vroom_example("mtcars.csv"))

and it would just sit there running indefinitely. When I am installing I do get the following message:

Package available only in source form, and may need compilation of C/C++/Fortran

I've tested it on two separate machines (Rstudio 1.1.456 and 1.2.1335 each, also tested with R Gui), updated R from 3.5.1 to 3.6, and tried the development version as well, to no avail. Not sure what is the issue. Were there any similar reports, or any solutions you may suggest?

Thank you.

@jimhester

This comment has been minimized.

Copy link
Member

commented May 8, 2019

There was an issue in earlier RStudio versions, but I think it should be fixed in the 1.2 release, see https://github.com/r-lib/vroom#rstudio-caveats.

Try turning off the refresh automatically and see if that fixes the hang.

@jimhester

This comment has been minimized.

Copy link
Member

commented May 8, 2019

Oh you also mention testing with R Gui. I have never encountered this and it does work fine on other Windows machines, including the CRAN windows machines and my personal one.

Can you provide any more relevant details about the machines you are testing on? What version of windows and what type of hard drive are they using?

@abfleishman

This comment has been minimized.

Copy link

commented May 8, 2019

I had the same issue. I went back and tried to look at the install printout and saw some errors, here is one example:
image

Here is printout from version:
image

I am using rstudio 1.2.1335 on Windows 10

@jimhester

This comment has been minimized.

Copy link
Member

commented May 8, 2019

@abfleishman Can you paste the full installation log in a text document and attach it to this issue?

e.g. everything after

install.packages("vroom")

Until you get back the R command prompt?

@sysilviakim

This comment has been minimized.

Copy link
Author

commented May 8, 2019

Hi Jim,

My machine is Windows 10 and here is the session info:

> sessionInfo()
R version 3.6.0 (2019-04-26) 
Platform: x86_64-w64-mingw32/x64 (64-bit) 
Running under: Windows 10 x64 (build 17134)  

Matrix products: default  

locale: 
[1] LC_COLLATE=English_United States.1252  
[2] LC_CTYPE=English_United States.1252    
[3] LC_MONETARY=English_United States.1252 
[4] LC_NUMERIC=C                           
[5] LC_TIME=English_United States.1252  
    
attached base packages: 
[1] stats     graphics  grDevices utils     datasets  methods   
[7] base       

other attached packages: 
[1] vroom_1.0.0 

loaded via a namespace (and not attached):  
[1] tidyselect_0.2.5 compiler_3.6.0   magrittr_1.5      
[4] tools_3.6.0      glue_1.3.1       rstudioapi_0.10   
[7] crayon_1.3.4     Rcpp_1.0.1       rlang_0.3.4      
[10] purrr_0.3.2
--

I tried turning off the refresh automatically---didn't work. It's not an Rstudio problem, because mine is 1.2+ and it happens on a command-line R as well.

There was an issue in earlier RStudio versions, but I think it should be fixed in the 1.2 release, see https://github.com/r-lib/vroom#rstudio-caveats.

Try turning off the refresh automatically and see if that fixes the hang.

@abfleishman

This comment has been minimized.

Copy link

commented May 8, 2019

here it is attached as a txt.
vroom_install_log.txt

@jimhester

This comment has been minimized.

Copy link
Member

commented May 8, 2019

Thanks! Does it hang even if you run something like the following?

vroom::vroom("abc\n123\n")
@abfleishman

This comment has been minimized.

Copy link

commented May 8, 2019

Yes still hangs there with vroom::vroom("abc\n123\n")

@jimhester

This comment has been minimized.

Copy link
Member

commented May 8, 2019

What about vroom::vroom("abc\n123\n", progress = FALSE)

@jimhester

This comment has been minimized.

Copy link
Member

commented May 8, 2019

Ok I can reproduce this with my windows machine, using progress = FALSE is a workaround for now, I will look into getting it fixed soon!

@abfleishman

This comment has been minimized.

Copy link

commented May 8, 2019

using vroom::vroom("abc\n123\n", progress = FALSE) worked fine. excited to to try in production! Thanks!

@sysilviakim

This comment has been minimized.

Copy link
Author

commented May 8, 2019

That is really interesting, specifying progress = FALSE solved the issue for me as well.

@jimhester jimhester closed this in 8a3813a May 9, 2019

@jimhester

This comment has been minimized.

Copy link
Member

commented May 9, 2019

Sorry for this issue, the root issue was a deadlock in the multi-threaded progress bar that only manifested on Windows.

It was not caught because I primarily develop on macOS (it doesn't occur there) and the package tests don't use the progress bar.

My apologies, I will release a new version to CRAN soon with this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.