Is there a way to enforce that it prints the entire diff, instead of having "and # more" at the bottom?

[Jesse-Kerr]

If I compare two character strings:

chr1 <- "This is a poem,
    a poem about nothing,
    Just used for testing,
    Not made for thinking,
    Just let it go
    Still just a poem
    Not a great poem
    But it's for testing
    And thus it's a poem
    The end"

chr2 <- ""

waldo::compare(chr1, chr2)

This prints the entire diff.

But if I add another line to my poem:

chr1 <- "This is a poem,
    a poem about nothing,
    Just used for testing,
    Not made for thinking,
    Just let it go
    Still just a poem
    Not a great poem
    But it's for testing
    And thus it's a poem
    The end
    Wait one more"

chr2 <- ""

waldo::compare(chr1, chr2)

The last line of the diff gets cut off. I think it stops printing after 10 diff lines? I'm guessing there is a Sys.env I might need to change?

[hadley]

Hmmm, this is supposed to do it, it but clearly doesn't:

chr1 <- "This is a poem,
    a poem about nothing,
    Just used for testing,
    Not made for thinking,
    Just let it go
    Still just a poem
    Not a great poem
    But it's for testing
    And thus it's a poem
    The end
    Wait one more"

chr2 <- ""

print(waldo::compare(chr1, chr2), n = Inf)
#>      lines(old[[1]])              | lines(new[[1]])               
#>  [1] "This is a poem,"            -                               
#>  [2] "    a poem about nothing,"  -                               
#>  [3] "    Just used for testing," -                               
#>  [4] "    Not made for thinking," -                               
#>  [5] "    Just let it go"         -                               
#>  [6] "    Still just a poem"      -                               
#>  [7] "    Not a great poem"       -                               
#>  [8] "    But it's for testing"   -                               
#>  [9] "    And thus it's a poem"   -                               
#> [10] "    The end"                -                               
#>  ... ...                            ...             and 1 more ...

^{Created on 2020-10-16 by the reprex package (v0.3.0.9001)}

[hadley]

Ah, ok there are two places that truncation occurs:

• format_diff_matrix() where we show all difference when run in CI, and only 10 when run normally
• print.waldo.compare() where we show all difference when run in CI, and only 10 when run normally

It seems reasonable to give these the same behaviour, and control through a single param in compare()

[Jesse-Kerr]

Thank you, works great!