From 0c79c2073fae98f31cb7cdf478689a5112e8a95a Mon Sep 17 00:00:00 2001 From: shikokuchuo <53399081+shikokuchuo@users.noreply.github.com> Date: Tue, 15 Jul 2025 21:10:07 +0100 Subject: [PATCH 1/5] Polish news --- NEWS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NEWS.md b/NEWS.md index 02ade49..75d9355 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,6 +1,6 @@ # watcher (development version) -* Watcher can now use a system-installed 'libfswatch' in a non-standard filesystem location. +* Watcher can now use a system 'libfswatch' installed in a non-standard location (#28). # watcher 0.1.3 From 921fe50bf4e92d4c44429f9b901b4224c8697c3a Mon Sep 17 00:00:00 2001 From: shikokuchuo <53399081+shikokuchuo@users.noreply.github.com> Date: Tue, 15 Jul 2025 21:21:56 +0100 Subject: [PATCH 2/5] Ignore revdep --- .Rbuildignore | 1 + .gitignore | 1 + 2 files changed, 2 insertions(+) diff --git a/.Rbuildignore b/.Rbuildignore index b0db0f5..01c7858 100644 --- a/.Rbuildignore +++ b/.Rbuildignore @@ -6,6 +6,7 @@ ^_pkgdown\.yml$ ^docs$ ^pkgdown$ +^revdep$ ^codecov\.yml$ ^cran-comments\.md$ ^[\.]?air\.toml$ diff --git a/.gitignore b/.gitignore index 2895218..04db3c7 100644 --- a/.gitignore +++ b/.gitignore @@ -4,5 +4,6 @@ .Ruserdata install docs +revdep .vscode air.toml From 9525384b292750e80b181712504443c9f50e849c Mon Sep 17 00:00:00 2001 From: shikokuchuo <53399081+shikokuchuo@users.noreply.github.com> Date: Tue, 15 Jul 2025 21:48:21 +0100 Subject: [PATCH 3/5] Avoid inlining statics --- src/watcher.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/watcher.c b/src/watcher.c index 1ae5ae9..61379ec 100644 --- a/src/watcher.c +++ b/src/watcher.c @@ -14,14 +14,14 @@ static void Wprintf(const char *fmt, ...) { } -static inline void watcher_error(FSW_HANDLE handle, const char *msg) { +static void watcher_error(FSW_HANDLE handle, const char *msg) { if (handle) fsw_destroy_session(handle); Rf_error("%s", msg); } -static inline void watcher_unwind(watcher_cb *wcb) { +static void watcher_unwind(watcher_cb *wcb) { if (wcb->paths) { for (unsigned int i = 0; i < wcb->event_num; i++) { From 060615ddb70a53f756f48f5e114292c6812d8c7e Mon Sep 17 00:00:00 2001 From: shikokuchuo <53399081+shikokuchuo@users.noreply.github.com> Date: Tue, 15 Jul 2025 22:00:04 +0100 Subject: [PATCH 4/5] Update CRAN comments --- cran-comments.md | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/cran-comments.md b/cran-comments.md index 0037a2f..9f32410 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,3 +1,14 @@ ## R CMD check results -0 errors | 0 warnings | 0 notes +0 errors | 0 warnings | 1 note + +Note on CRAN incoming feasibility: change of maintainer email address. +I've already emailed cran-submissions about this. + +## revdepcheck results + +We checked 1 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package. + + * We saw 0 new problems + * We failed to check 0 packages + From 6f035cf617b1d22fa1b7527e9833fc73b17790b6 Mon Sep 17 00:00:00 2001 From: shikokuchuo <53399081+shikokuchuo@users.noreply.github.com> Date: Wed, 16 Jul 2025 08:05:58 +0100 Subject: [PATCH 5/5] watcher 0.1.4 --- DESCRIPTION | 2 +- NEWS.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/DESCRIPTION b/DESCRIPTION index 35d37ac..46c5059 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,7 +1,7 @@ Type: Package Package: watcher Title: Watch the File System for Changes -Version: 0.1.3.9000 +Version: 0.1.4 Authors@R: c( person("Charlie", "Gao", , "charlie.gao@posit.co", role = c("aut", "cre"), comment = c(ORCID = "0000-0002-0750-061X")), diff --git a/NEWS.md b/NEWS.md index 75d9355..135df50 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,4 +1,4 @@ -# watcher (development version) +# watcher 0.1.4 * Watcher can now use a system 'libfswatch' installed in a non-standard location (#28).