Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All modifying functions should ignore empty/missing inputs #134

Closed
hadley opened this issue Oct 18, 2016 · 0 comments
Closed

All modifying functions should ignore empty/missing inputs #134

hadley opened this issue Oct 18, 2016 · 0 comments

Comments

@hadley
Copy link
Member

@hadley hadley commented Oct 18, 2016

library(xml2)
x <- read_xml("<a><b/></a>")
xml_remove(xml_find_all(x, ".//c"))

Also need to handle missing nodes, and all attribute settors etc.

@hadley hadley changed the title xml_remove should ignore empty inputs All modifying functions should ignore empty/missing inputs Oct 25, 2016
jimhester added a commit that referenced this issue Dec 9, 2016
Addresses part of #134, still need to account for zero length nodesets.
@jimhester jimhester closed this in 98ee82c Dec 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant