New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`xml2_serialize()` should create and open a connection if given a filename. #179

Closed
jimhester opened this Issue May 19, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@jimhester
Member

jimhester commented May 19, 2017

Issue Description and Expected Result

Currently connection is passed directly to base::serialize, which expects an open connection.

Reproducible Example

library(xml2)
x <- read_xml("<x><y/><z/></x>")
xml_serialize(x, "test")
#> Error in serialize(structure(as.character(object, ...), class = "xml_serialized_document"), : 'connection' must be a connection

@jimhester jimhester closed this in dd1832b Jan 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment