Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FR: file argument for xml_structure #244

Closed
MichaelChirico opened this issue Jan 30, 2019 · 2 comments
Closed

FR: file argument for xml_structure #244

MichaelChirico opened this issue Jan 30, 2019 · 2 comments

Comments

@MichaelChirico
Copy link
Contributor

xml_structure is great, but the cat output can get quite long...

As opposed to write_xml, file argument adds flexibility to shut this argument on/off without changing much else while using xml_structure.

Would be straightforward to add since this argument can just be passed to cat directly, IIUC.

Happy to try out a PR if it sounds like a good idea.
@MichaelChirico
Copy link
Contributor Author

Could even just add a ... argument and pass everything to cat

@jimhester
Copy link
Member

Passing the dots to cat() seems fine to me, happy to review a PR if you would like!

MichaelChirico pushed a commit to MichaelChirico/xml2 that referenced this issue Feb 12, 2019
add ... to xml_structure and descendents, closes r-lib#244
0ed158b
@MichaelChirico MichaelChirico mentioned this issue Feb 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jimhester @MichaelChirico