Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is `curl` not a dependency of `xml2`? #262

Closed
trannhatanh89 opened this issue Jun 7, 2019 · 1 comment

Comments

@trannhatanh89
Copy link

@trannhatanh89 trannhatanh89 commented Jun 7, 2019

I am not sure why curl is not a dependency of xml2. download_xml and download_html both use curl as defaults, and will give errors if that package is not installed. At this time, the error message is not very clear, and hard to trace if those download functions are used as part of a bigger code chunk or a function. I also got issues with a package that's depending on xml2, and it's even harder to track where the error came from in that instance.

install.packages("xml2")
#> Installing package into 'C:/Users/ant5152/Documents/R/win-library/3.6'
#> (as 'lib' is unspecified)
#> package 'xml2' successfully unpacked and MD5 sums checked
#> 
#> The downloaded binary packages are in
#>  C:\Users\ant5152\AppData\Local\Temp\Rtmp2xWOfd\downloaded_packages

xml2::download_xml("https://www.proteinatlas.org/ENSG00000134057.xml")
#> Error in loadNamespace(name): there is no package called 'curl'
@jimhester jimhester closed this in 4d49ba5 Jul 19, 2019
@trannhatanh89

This comment has been minimized.

Copy link
Author

@trannhatanh89 trannhatanh89 commented Jul 19, 2019

Thank you for addressing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.