New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable non-character attributes to be set. #122

Merged
merged 1 commit into from Dec 6, 2016

Conversation

Projects
None yet
2 participants
@sjp
Contributor

sjp commented Sep 12, 2016

This should fix #117. For similar reasons (i.e. working with SVG documents) it would be nice not to have to specify every attribute as a character vector.

Basically this change will cast non-character arguments via as.character().

@jimhester jimhester merged commit fa5b6b4 into r-lib:master Dec 6, 2016

3 checks passed

codecov/patch 100% of diff hit (target 77.31%)
Details
codecov/project 77.60% (+0.29%) compared to 1a75d4a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment