New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand paths before passing to libxml2 #86

Merged
merged 3 commits into from May 13, 2016

Conversation

Projects
None yet
3 participants
@jimhester
Member

jimhester commented May 12, 2016

Fixes #80

@hadley

This comment has been minimized.

Member

hadley commented May 12, 2016

Might be better to do this in C with R_ExpandFileName ?

@jimhester

This comment has been minimized.

Member

jimhester commented May 12, 2016

@hadley

This comment has been minimized.

Member

hadley commented May 13, 2016

Right, it just feels a little safer to do this in C to me.

@jimhester

This comment has been minimized.

Member

jimhester commented May 13, 2016

Ok it is so (1c303cc)

@hadley

This comment has been minimized.

Member

hadley commented May 13, 2016

Perfect. Can you add a bullet to news too?

@codecov-io

This comment has been minimized.

codecov-io commented May 13, 2016

Current coverage is 50.00%

Merging #86 into master will not change coverage

@@             master        #86   diff @@
==========================================
  Files            29         29          
  Lines           852        852          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            426        426          
  Misses          426        426          
  Partials          0          0          

Powered by Codecov. Last updated by bbb035c...3cc330a

@jimhester

This comment has been minimized.

Member

jimhester commented May 13, 2016

done!

@hadley hadley merged commit f74a9d0 into r-lib:master May 13, 2016

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment