Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libxml2 parsing options #88

Merged
merged 8 commits into from May 19, 2016

Conversation

Projects
None yet
4 participants
@jimhester
Copy link
Member

commented May 17, 2016

Continuation of #85

Fixes #62, #49

@codecov-io

This comment has been minimized.

Copy link

commented May 17, 2016

Current coverage is 59.65%

Merging #88 into master will increase coverage by 0.27%

@@             master        #88   diff @@
==========================================
  Files            30         30          
  Lines          1235       1249    +14   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            733        745    +12   
- Misses          502        504     +2   
  Partials          0          0          

Powered by Codecov. Last updated by 7e980dd...4b8da74

DESCRIPTION Outdated
@@ -1,5 +1,5 @@
Package: xml2
Version: 0.1.2.9000
Version: 0.1.2.9200

This comment has been minimized.

Copy link
@hadley

hadley May 17, 2016

Member

BTW I don't normally bother bumping this unless it's needed for a revdep.

This comment has been minimized.

Copy link
@jimhester

jimhester May 18, 2016

Author Member

It was bumped by the original upstream commit, but good to know!

NEWS.md Outdated
@@ -1,5 +1,11 @@
# xml2 0.1.2.9000

* `xml_read()` now drops blank text nodes, preserves behavior of XML package

This comment has been minimized.

Copy link
@hadley

hadley May 17, 2016

Member

Maybe "mimicking" behaviour of XML package?

@@ -40,6 +42,8 @@ encoding directive, this allows you to supply a default.}

\item{as_html}{Optionally parse an xml file as if it's html.}
\item{allow_huge}{Remove size and node limits when parsing.}

This comment has been minimized.

Copy link
@hadley

hadley May 17, 2016

Member

Maybe mention the downsides?

@jimhester jimhester force-pushed the jimhester:shabbychef-master branch from e70c13d to 3f25fb6 May 18, 2016

@jimhester jimhester changed the title Option for XML_PARSE_HUGE and turn on {HT,X}ML_PARSE_NOBLANKS libxml2 parsing options May 18, 2016

@jimhester

This comment has been minimized.

Copy link
Member Author

commented May 18, 2016

I ended up exposing all of the libxml2 parsing options to the R side in 3f25fb6. They can be specified as a character vector of options to set. The option descriptions come from http://www.xmlsoft.org/html/libxml-parser.html#xmlParserOption

@hadley

This comment has been minimized.

Copy link
Member

commented May 18, 2016

This looks great

@jimhester jimhester force-pushed the jimhester:shabbychef-master branch 3 times, most recently from e5fc442 to 9b1367d May 19, 2016

@jimhester jimhester force-pushed the jimhester:shabbychef-master branch from 9b1367d to 26e1043 May 19, 2016

@jimhester jimhester merged commit 80a1d52 into r-lib:master May 19, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.