New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add response methods for read_xml and read_html #93

Merged
merged 2 commits into from May 27, 2016

Conversation

Projects
None yet
4 participants
@jimhester
Member

jimhester commented May 27, 2016

Also convert read_html to a generic.

Perhaps the need_package("xml") is unnecessary, as how do you get a response object without having httr installed, but I put it in there to be safe.

Add response methods for read_xml and read_html
Also convert read_html to a generic

Fixes #63
@codecov-io

This comment has been minimized.

codecov-io commented May 27, 2016

Current coverage is 59.59%

Merging #93 into master will increase coverage by 0.23%

@@             master        #93   diff @@
==========================================
  Files            30         30          
  Lines          1345       1356    +11   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            798        808    +10   
- Misses          547        548     +1   
  Partials          0          0          

Powered by Codecov. Last updated by 8a78f9b...4d37b4a

R/utils.R Outdated
@@ -20,3 +20,13 @@ quote_str <- function(x, quote = "\"") {
paste0(quote, x, quote)
}
is_installed <- function(pkg) {
system.file(package = pkg) != ""

This comment has been minimized.

@hadley

hadley May 27, 2016

Member

Can we use requireNamespace(quietly = TRUE) instead?

This comment has been minimized.

@jimhester

This comment has been minimized.

@hadley

hadley May 27, 2016

Member

You should never trust that guy's code!

@hadley

This comment has been minimized.

Member

hadley commented May 27, 2016

LGTM

@jimhester jimhester merged commit d7b883d into r-lib:master May 27, 2016

3 checks passed

codecov/patch 90.91% of diff hit (target 59.33%)
Details
codecov/project 59.59% (+0.23%) compared to 8a78f9b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mjkallen

This comment has been minimized.

mjkallen commented on tests/testthat/test-read-xml.R in 90fc759 Jun 27, 2016

@jimhester looks like you added the same test twice here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment