New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with the upcoming version of testthat #41

Closed
Enchufa2 opened this Issue Mar 5, 2016 · 0 comments

Comments

Projects
None yet
1 participant
@Enchufa2
Member

Enchufa2 commented Mar 5, 2016

1 error  | 0 warnings | 0 notes.

    checking tests ... ERROR
    Running the tests in ‘tests/testthat.R’ failed.
    Last 13 lines of output:
      > test_check("simmer")
      1. Failure: the trajectory stores the right number of activities
(@test-trajectory.R#76)
      `output` does not match ".*(13
activities.*Seize.*nurse.*1.*Timeout.*function.*Release.*nurse.*1.*Branch.*1.*6
activities.*Seize.*doctor.*function.*Timeout.*function.*Release.*doctor.*function.*Branch.*1.*3
activities.*Seize.*administration.*1.*Timeout.*1.*Release.*administration.*1.*Rollback.*1.*Branch.*1.*Rollback.*1.*Rollback.*function.*SetAttribute.*1.*SetAttribute.*function).*".
      Actual value: ""


      Trajectory: anonymous, 1 activities
      testthat results
================================================================
      OK: 192 SKIPPED: 0 FAILED: 1
      1. Failure: the trajectory stores the right number of activities
(@test-trajectory.R#76)

      Error: testthat unit tests failed
      Execution halted

There are two common classes of
new failures caused by this version of testthat:

  1. expect_output() no longer automatically prints the object. You'll need to
    explicitly print() if you want to check the output of a print method.
  2. expect_error() now only compares against the actual error message,
    not the prefix, e.g. "Error in foo(): ". You might need to change you
    match message to take this into account.

It seems the problem falls into category 1.

@Enchufa2 Enchufa2 added this to the v3.2.0 milestone Mar 5, 2016

@Enchufa2 Enchufa2 closed this in 27ab890 Apr 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment