New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_dataframe: attachment of precomputed data (closes #123) #140

Merged
merged 17 commits into from Mar 24, 2018

Conversation

Projects
None yet
1 participant
@Enchufa2
Member

Enchufa2 commented Mar 12, 2018

WIP. Some testing needed.

@codecov

This comment has been minimized.

codecov bot commented Mar 12, 2018

Codecov Report

Merging #140 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #140      +/-   ##
========================================
+ Coverage   99.96%   100%   +0.03%     
========================================
  Files          22     22              
  Lines        2651   2786     +135     
========================================
+ Hits         2650   2786     +136     
+ Misses          1      0       -1
Impacted Files Coverage Δ
src/simulator.h 100% <100%> (ø) ⬆️
src/process.h 100% <100%> (ø) ⬆️
R/utils.R 100% <100%> (+1.36%) ⬆️
R/wrap-class.R 100% <100%> (ø) ⬆️
R/trajectory-activities.R 100% <100%> (ø) ⬆️
R/simmer-class.R 100% <100%> (ø) ⬆️
src/process.cpp 100% <100%> (ø) ⬆️
src/activity.h 100% <100%> (ø) ⬆️
R/wrap-methods.R 100% <100%> (ø) ⬆️
src/simmer.h 100% <100%> (ø) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddd0dc7...ff90b09. Read the comment docs.

Enchufa2 added some commits Mar 12, 2018

@Enchufa2

This comment has been minimized.

Member

Enchufa2 commented Mar 13, 2018

Ready.

Enchufa2 added some commits Mar 17, 2018

@Enchufa2 Enchufa2 merged commit d02b412 into master Mar 24, 2018

4 checks passed

codecov/patch 100% of diff hit (target 99.96%)
Details
codecov/project 100% (+0.03%) compared to ddd0dc7
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Enchufa2 Enchufa2 deleted the feature-data branch Mar 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment