Skip to content

add support for variable batch sizes #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 10, 2021
Merged

Conversation

Enchufa2
Copy link
Member

Enhance batch interface to accept a function as parameter n. This max size is evaluated with the first arrival initiating the batch and stored in the Batched object, which ensures that this limit is not exceeded.

Closes #245.

@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #258 (e370cf1) into master (f58ad54) will decrease coverage by 0.22%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #258      +/-   ##
==========================================
- Coverage   99.64%   99.42%   -0.23%     
==========================================
  Files          47       47              
  Lines        2828     2784      -44     
==========================================
- Hits         2818     2768      -50     
- Misses         10       16       +6     
Impacted Files Coverage Δ
R/simmer-methods.R 99.54% <ø> (ø)
R/generators.R 100.00% <100.00%> (ø)
R/trajectory-activities.R 98.73% <100.00%> (+0.02%) ⬆️
inst/include/simmer/activity/arrival.h 98.83% <100.00%> (-0.04%) ⬇️
inst/include/simmer/common.h 100.00% <100.00%> (ø)
inst/include/simmer/process/arrival.h 97.14% <100.00%> (-1.38%) ⬇️
inst/include/simmer/process/arrival_impl.h 96.42% <100.00%> (-3.58%) ⬇️
inst/include/simmer/process/batched.h 100.00% <100.00%> (ø)
inst/include/simmer/process/datasrc.h 97.67% <100.00%> (-2.33%) ⬇️
inst/include/simmer/process/generator.h 100.00% <100.00%> (ø)
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a932d57...e370cf1. Read the comment docs.

@Enchufa2 Enchufa2 merged commit 18564fd into master Aug 10, 2021
@Enchufa2 Enchufa2 deleted the feature/dyn-batch-size branch August 10, 2021 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for variable batch sizes
1 participant