Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Bank vignette corrections #283

Closed
wants to merge 2 commits into from
Closed

Small Bank vignette corrections #283

wants to merge 2 commits into from

Conversation

damonbayer
Copy link

Two changes:

  1. Typo in the first bank vignette.
  2. The code to calculate number_balked yields 0, when five customers balk in the log. When a customer balks, their activity_time is 0, so I used this to count the number of balks. Maybe there is a better way to calculate this.

@Enchufa2 Enchufa2 closed this in 056418f Jun 24, 2022
@Enchufa2
Copy link
Member

Many thanks, but I'd prefer to add a leave activity, which sets finished to FALSE, and keep the calculation, as you can see in the commit above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants