Skip to content

Draft vignette of The Bank Tutorial Part 1 from SimPy v2 #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2016

Conversation

nacnudus
Copy link
Contributor

First draft. Sorry this took so long. The section "More customers" is a bit hacky -- see #65.

@coveralls
Copy link

coveralls commented Jun 28, 2016

Coverage Status

Coverage remained the same at 92.657% when pulling 76dbb2e on nacnudus:bank into de607ee on r-simmer:master.

@Enchufa2
Copy link
Member

Awesome job, thank you very much! Some comments:

  • As I said in Performance improvement: batched generation #65, every is going to be removed, because, since Performance improvement: batched generation #65, its behaviour can be easily replicated with function() c(...). Please, use its old recipe to define this wait function, as you already did, and remove the references to every.
  • I would like this vignette (and future parts) to appear right after Advanced Trajectory Usage. So, please, rename the files as
    • D-bank-1.Rmd
    • E-queueing-systems.Rmd
    • F-ctmc.Rmd
  • Please, specify {r, message=FALSE} in those chunks where you load dplyr in order to hide the attaching messages.
  • Of course, if you wish, you can use Python chunks in order to make comparisons, etc. Also your judgement is welcome: "this is easier with SimPy, this is more intuitive with simmer"... what you feel is appropriate. 😉

@nacnudus
Copy link
Contributor Author

Useful comments, thanks.

  • Instead of every, I've used it's old recipe and called it loop. Since it's a slightly fancy use of environments, I've linked to Advanced R rather than explain exactly how it works.
  • Might SimPy comparisons be better in a separate vignette? Then the Bank ones would be suitable for teaching a pure simmer class.

@coveralls
Copy link

coveralls commented Jun 29, 2016

Coverage Status

Coverage remained the same at 92.657% when pulling 0b0d63a on nacnudus:bank into de607ee on r-simmer:master.

@Enchufa2
Copy link
Member

Instead of every, I've used it's old recipe and called it loop. Since it's a slightly fancy use of environments, I've linked to Advanced R rather than explain exactly how it works.

Very appropriate. Maybe it's worth mentioning also that this kind of construction is called closure in R.

Might SimPy comparisons be better in a separate vignette? Then the Bank ones would be suitable for teaching a pure simmer class.

Ok. Totally agree.

BTW, there is still a chunk using every.

@nacnudus
Copy link
Contributor Author

Oops. Mentioned closure, removed the stray every chunk, and squashed the commits.

@Enchufa2
Copy link
Member

Perfect! Thanks again! Merging...

@Enchufa2 Enchufa2 merged commit 211be46 into r-simmer:master Jun 29, 2016
@nacnudus nacnudus deleted the bank branch June 29, 2016 12:57
@coveralls
Copy link

coveralls commented Jun 29, 2016

Coverage Status

Coverage remained the same at 92.657% when pulling dcaf0ea on nacnudus:bank into de607ee on r-simmer:master.

@Enchufa2 Enchufa2 added this to the v3.4.0 milestone Jul 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants