Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd gcc patch for libbacktrace #148
Open
Conversation
|
Yes the artifacts from the pull requests will contain the packages. You can download them manually from GHA, and then install locally like so: pacman -Su mingw-w64-x86_64-gcc-8.3.0-9500-any.pkg.tar.xzYou can also try subitting the patch to https://github.com/msys2/MINGW-packages for feedback. |
|
Confirmed that installation of the package fixes the downstream issue. |
|
Submitted bug to gcc issue tracker too: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96948. |
|
Simplified, and submitted upstream as msys2/MINGW-packages#6962. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This patch allows obtaining a nice native backtrace on mingw64 with libbacktrace. Without this patch, we can still get a backtrace but miss the exact position in the function.
Downstream: ianlancetaylor/libbacktrace#43 (comment)
I hope the GCC maintainers can review it so that we ca get more confidence here.
Does the pull request already creates binary packages which I can download and install on my system?