Let make take other falsy values for content.

r00k · Mar 21, 2012 · c7034b9 · c7034b9
1 parent 69d2c50
commit c7034b9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/backbone.js b/backbone.js
@@ -1192,7 +1192,7 @@
     make: function(tagName, attributes, content) {
       var el = document.createElement(tagName);
       if (attributes) $(el).attr(attributes);
-      if (content !== undefined) $(el).html(content);
+      if (content != null) $(el).html(content);
       return el;
     },
 

diff --git a/test/view.js b/test/view.js
@@ -33,9 +33,12 @@ $(document).ready(function() {
     equal($(div).text(), 'one two three');
   });
 
-  test("View: make can take an argument of 0", function() {
+  test("View: make can take falsy values for content", function() {
     var div = view.make('div', {id: 'test-div'}, 0);
     equal($(div).text(), '0');
+
+    var div = view.make('div', {id: 'test-div'}, '');
+    equal($(div).text(), '');
   });
 
   test("View: initialize", function() {