Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
rebase -i: support --ignore-date #4
2 times, most recently
Aug 4, 2019
tgummerer left a comment
Unfortunately you can't refer to a commit like that when it's part of a patch series, as the commit ID will be different once Junio actually applies the earlier patch. Instead, the patch can just be referred as "a previous patch" or something like that.
I would also make what you have as the second commit in the series ("sequencer: rename amend_author to author_to_free") the first commit, as it's really a preparatory step that makes the commit after it easier to read. Right now it's more of an "oops, we should have named this differently, let's do it now" commit, which we generally prefer not to do in this project.
Other than those two nits the code looks good to me