Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specific exception for retrieving missing required values from ConnectionFactoryOptions #122

Closed
mp911de opened this issue Sep 19, 2019 · 0 comments
Labels
target: 0.9.x Issues we want to address with 0.9.x. type: enhancement A general enhancement
Milestone

Comments

@mp911de
Copy link
Member

mp911de commented Sep 19, 2019

We should consider introducing a dedicated exception when retrieving a value from ConnectionFactoryOptions that is not present. Right now, IllegalStateException gets thrown. Although the state can be considered illegal, the exception should rather express a motivation and indication that they can do something about (e.g. adding the missing option).

We could introduce MissingOptionException that is either a subclass of R2dbcException or IllegalStateException and that holds also the requested Option in addition to its message.

From working with ConnectionFactoryOptions via ConnectionFactoryProvider, that exception (and associated error handling behavior) showed that the current IllegalStateException gets propagated into the user-space and users or applications get in touch with that exception.

@mp911de mp911de added type: enhancement A general enhancement for: team-attention An issue we need to discuss as a team to make progress labels Sep 19, 2019
@mp911de mp911de added the target: 0.9.x Issues we want to address with 0.9.x. label Feb 7, 2020
@mp911de mp911de added this to the 0.9.0.M1 milestone Feb 23, 2021
@mp911de mp911de removed the for: team-attention An issue we need to discuss as a team to make progress label Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
target: 0.9.x Issues we want to address with 0.9.x. type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant