New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for .NET Standard #28

Merged
merged 33 commits into from May 25, 2018

Conversation

Projects
None yet
2 participants
@tpluscode
Contributor

tpluscode commented May 20, 2018

closes #26

@mchaloupka

This comment has been minimized.

Show comment
Hide comment
@mchaloupka

mchaloupka May 20, 2018

Contributor

I would recommend also --include-symbols for dotnet pack command. Consider also --include-sources.
https://docs.microsoft.com/en-us/dotnet/core/tools/dotnet-pack?tabs=netcore2x

Contributor

mchaloupka commented May 20, 2018

I would recommend also --include-symbols for dotnet pack command. Consider also --include-sources.
https://docs.microsoft.com/en-us/dotnet/core/tools/dotnet-pack?tabs=netcore2x

@mchaloupka

This comment has been minimized.

Show comment
Hide comment
@mchaloupka

mchaloupka May 20, 2018

Contributor

According to the build it looks like you have some issue with AssemblyFileVersionAttribute (probably added additional one using the tool). I do not understand why the build is not failed. Maybe it is needed to have it as separate steps (build and pack). I do not know.

Contributor

mchaloupka commented May 20, 2018

According to the build it looks like you have some issue with AssemblyFileVersionAttribute (probably added additional one using the tool). I do not understand why the build is not failed. Maybe it is needed to have it as separate steps (build and pack). I do not know.

@tpluscode

This comment has been minimized.

Show comment
Hide comment
@tpluscode

tpluscode May 21, 2018

Contributor

About symbols, I've previously used GitLink. Will see to configure this here as well.

Contributor

tpluscode commented May 21, 2018

About symbols, I've previously used GitLink. Will see to configure this here as well.

tpluscode added some commits May 21, 2018

@tpluscode

This comment has been minimized.

Show comment
Hide comment
@tpluscode

tpluscode May 23, 2018

Contributor

@mchaloupka, while I battle dependencies which act weird with dotnet tooling, please tell me if targeting .NET Standard 2.0 and .NET Framework 4 would be good enough? I wanted to do .NET Standard 1.5 but it lack some APIs which may or may not be required (wait till I run tests against the official suite)

Contributor

tpluscode commented May 23, 2018

@mchaloupka, while I battle dependencies which act weird with dotnet tooling, please tell me if targeting .NET Standard 2.0 and .NET Framework 4 would be good enough? I wanted to do .NET Standard 1.5 but it lack some APIs which may or may not be required (wait till I run tests against the official suite)

@mchaloupka

This comment has been minimized.

Show comment
Hide comment
@mchaloupka

mchaloupka May 23, 2018

Contributor

.NET Standard 2.0 seems completely fine to me. I guess that .NET 4 is currently needed only on Windows PosReady 2009 (which will be out of support 2019Q2), so I would be even ok if you will target some higher .NET version.

Contributor

mchaloupka commented May 23, 2018

.NET Standard 2.0 seems completely fine to me. I guess that .NET 4 is currently needed only on Windows PosReady 2009 (which will be out of support 2019Q2), so I would be even ok if you will target some higher .NET version.

@mchaloupka

This comment has been minimized.

Show comment
Hide comment
@mchaloupka

mchaloupka May 25, 2018

Contributor

It seems like you are missing dotnet-xunit in TCode.r2rml4net.Mapping.Tests\paket.references. Otherwise it looks almost done. Or do you have any additional plans what you want to add?

Contributor

mchaloupka commented May 25, 2018

It seems like you are missing dotnet-xunit in TCode.r2rml4net.Mapping.Tests\paket.references. Otherwise it looks almost done. Or do you have any additional plans what you want to add?

tpluscode added some commits May 25, 2018

@tpluscode

This comment has been minimized.

Show comment
Hide comment
@tpluscode

tpluscode May 25, 2018

Contributor

Indeed I missed that, thanks.

any additional plans

GitLink has issues with dotnet tooling so I'll make a new ticket for that.
I will also want to run the w3c test suite on AppVeyor but this can be handled separately.
Finally there's StyleCop but it's not that important either.

I think I'm almost done here :)

Contributor

tpluscode commented May 25, 2018

Indeed I missed that, thanks.

any additional plans

GitLink has issues with dotnet tooling so I'll make a new ticket for that.
I will also want to run the w3c test suite on AppVeyor but this can be handled separately.
Finally there's StyleCop but it's not that important either.

I think I'm almost done here :)

@mchaloupka

This comment has been minimized.

Show comment
Hide comment
@mchaloupka

mchaloupka May 25, 2018

Contributor

One more thing I noticed is that you are creating two nuget packages. Is that intentional?

Contributor

mchaloupka commented May 25, 2018

One more thing I noticed is that you are creating two nuget packages. Is that intentional?

@tpluscode

This comment has been minimized.

Show comment
Hide comment
@tpluscode

tpluscode May 25, 2018

Contributor

Nope. It's actually something that I accidentally committed

Contributor

tpluscode commented May 25, 2018

Nope. It's actually something that I accidentally committed

@tpluscode tpluscode merged commit 217afcf into master May 25, 2018

2 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@tpluscode tpluscode deleted the vs2017 branch May 25, 2018

@mchaloupka

This comment has been minimized.

Show comment
Hide comment
@mchaloupka

mchaloupka May 25, 2018

Contributor

You can also update the badge in the Readme.md.

Please publish the nuget so I can start using the official one instead of local copy taken from the build.

Contributor

mchaloupka commented May 25, 2018

You can also update the badge in the Readme.md.

Please publish the nuget so I can start using the official one instead of local copy taken from the build.

@tpluscode

This comment has been minimized.

Show comment
Hide comment
@tpluscode

tpluscode May 26, 2018

Contributor

Just pushed r2rml4net.0.5.0-beta to nuget.org.

Contributor

tpluscode commented May 26, 2018

Just pushed r2rml4net.0.5.0-beta to nuget.org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment