Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flake8 to the testing #75

Merged
merged 2 commits into from Apr 27, 2018

Conversation

Projects
None yet
2 participants
@cclauss
Copy link
Contributor

commented Apr 26, 2018

cclauss
@r9y9

This comment has been minimized.

Copy link
Owner

commented Apr 27, 2018

Having automate flake8 is nice, but I'm not sure if --select=E901,E999,F821,F822,F823 is good. Is this a standard in a certain community? Why did you use that?

@cclauss

This comment has been minimized.

Copy link
Contributor Author

commented Apr 27, 2018

My sense is that E901,E999,F821,F822,F823 are the "showstopper" flake8 issues that can halt the runtime with a SyntaxError, NameError, etc. The other flake8 issues are merely "style violations" -- useful for readability but they do not effect runtime safety.

@cclauss

This comment has been minimized.

Copy link
Contributor Author

commented Apr 27, 2018

If you want to clean up ALL the issues from the second flake8 run and then require the code to pass ALL flake8 tests then I have no objection to that.

cclauss
@r9y9

This comment has been minimized.

Copy link
Owner

commented Apr 27, 2018

Got it, thanks for the explanation. Merging.

@r9y9 r9y9 merged commit 1886018 into r9y9:master Apr 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cclauss cclauss deleted the cclauss:patch-3 branch Apr 27, 2018

engiecat added a commit to engiecat/deepvoice3_pytorch that referenced this pull request May 5, 2018

Add flake8 to the testing (r9y9#75)
* Add flake8 to the testing

* Rerun tests

engiecat added a commit to engiecat/deepvoice3_pytorch that referenced this pull request May 5, 2018

Add flake8 to the testing (r9y9#75)
* Add flake8 to the testing

* Rerun tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.