New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize project with msgpack #151

Merged
merged 3 commits into from Aug 30, 2018

Conversation

Projects
None yet
1 participant
@ra-gg
Copy link
Owner

ra-gg commented Aug 30, 2018

No description provided.

ra-gg added some commits Aug 30, 2018

Introduce msgpack5
msgpack5実装はいくつかあったけど、以下の理由でmsgpack5を使うことにした

- msgpack-js-v5: Bufferを含むものをdecodeするとBufferではなく添字付きオブジェクトに変換されて型の意味が失われた、あとextを使ってundefinedに対応されてやめてくれになった
- msgpack5: importしたのを()しないといけないのがなんかキモいけど、Bufferにちゃんと対応していたのと、変な拡張とかも入ってなくて素直だった
Project saving with msgpack
ついでに obj.project にプロジェクト構造を吐くようにした。
これをすることで将来的に obj.editor にプロジェクトの状態を吐いたりできるようになる

@ra-gg ra-gg merged commit f28b08e into master Aug 30, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@ra-gg ra-gg deleted the feature/serialize-with-msgpack branch Aug 30, 2018

@ra-gg ra-gg added this to the v0.5.0 milestone Sep 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment