New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error notifications #187

Merged
merged 10 commits into from Jan 1, 2019

Conversation

Projects
None yet
1 participant
@ra-gg
Copy link
Owner

ra-gg commented Oct 15, 2018

Ticket: https://trello.com/c/R1FxGvmR/152-improve-expression-script-error-notification

Has breaking changes to public API?: No.

TODO

  • Bump up version delir-core

Summary

  • DelirCore: Refactor (rename) delir-core/exceptions to delir-core/Exceptions (No public API changed)
  • DelirCore: Add DelirCore.Exceptions.UserCodeException (New API)
  • DelirCore: Engine#{renderFrame,renderSequencial} now will rejects with UserCodeException (New feature)
    • In case, invalid p5.js script execution. or invalid expression code execution.
  • Delir: Display UserCodeException details in Notification.
UI Screenshot
image

Breaking changes (In delir-core Public API or Expression/p5.js intergration API)

  • none.

@ra-gg ra-gg added this to the Alpha.6 (v0.6.0) milestone Oct 26, 2018

@ra-gg ra-gg merged commit 1a076f9 into master Jan 1, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ra-gg ra-gg deleted the feature/improve-error-notification branch Jan 1, 2019

@ra-gg ra-gg referenced this pull request Jan 14, 2019

Merged

Release Alpha.6 #201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment