Permalink
9 comments
on commit
sign in to comment.
Browse files
Use full resolution for full-width featured image. Fixes #129
- Loading branch information
This comment has been minimized.
rad96 repliedAug 11, 2014
WHY?!?!?!?!!??! T_T
This comment has been minimized.
raamdev repliedAug 11, 2014
Why not? It makes sense that you'd want to use a higher resolution here, since the image takes up the full-width of the page.
This comment has been minimized.
raamdev repliedAug 11, 2014
I suppose I could leave it as it was (
array( 700, 700 )) and simply provide a means for hooking into that option (usingapply_filter()so that a site owner could change it to"full"if they'd prefer that.This comment has been minimized.
raamdev repliedAug 11, 2014
@rad96 I've changed it so that a site owner can override the default of 700px by adding a filter to
independent_publisher_full_width_featured_image_sizein a Child Theme. If nothing is overridden, the theme simply defaults to 700px. :) See e1fcd1b.This makes a lot more sense than changing the default size for everyone. Thanks for calling me out!
This comment has been minimized.
manishsuwal repliedAug 12, 2014
I don't know if my query belongs here.
Every time I upload a photo to my website, I resize my photo to 700px width. Does that make it load faster?
What's the best size to upload a photo to my website? Is it 1024px width? or 2048px width? or 700px width because that's the highest default? or width and size really doesn't matter?
This comment has been minimized.
raamdev repliedAug 13, 2014
@manishsuwal
After the next update goes out, you won't need to do that anymore. See Issue #131 for a fix that was recently committed that fixed this. From now on, when you upload an image (of any size bigger than 700px), WordPress will automatically create a resized version of the image at 700px, and it will use that size for featured images.
If you want to use a higher resolution than 700px for your featured images (which you might want to do if you use featured images as Post Covers, since those images are loaded at the full-width of the browser and you might want a higher resolution), you'll be able to manually specify a different size to use using the code I posted here: #129 (comment)
This comment has been minimized.
manishsuwal repliedAug 13, 2014
This comment has been minimized.
raamdev repliedAug 13, 2014
I think whatever size you want to upload is appropriate. I'd probably go with the highest resolution if you're intending for it to also be an online backup method. WordPress will resize the images to various sizes for you automatically, so you don't need to worry about the large size being too big.
This comment has been minimized.
manishsuwal repliedAug 13, 2014