Gallery issue #101

Closed
PavelTajdus opened this Issue May 14, 2014 · 9 comments

Projects

None yet

2 participants

@PavelTajdus
Contributor

I found, that gallery in post is not working as it should. On default wordpress templates is everything, as i set up. 4 pictures in row.
But Independend-publisher has pictures in gallery in one column.
gallery-issue

@raamdev
Owner
raamdev commented May 14, 2014

@Tajdik Thank you for reporting this bug! I have confirmed this issue and I will work on a fix for the next maintenance update.

@raamdev raamdev added the bug label May 14, 2014
@raamdev raamdev added this to the Next Release milestone May 14, 2014
@raamdev raamdev added a commit that closed this issue May 14, 2014
@raamdev Fix Gallery bug that forced galleries to one-column
Also includes enhancements to captions.

Resolves #101.
b27b9d0
@raamdev raamdev closed this in b27b9d0 May 14, 2014
@raamdev
Owner
raamdev commented May 14, 2014

This has been fixed in the latest development copy and will go out with the next release.

I also took the opportunity to enhance the caption support so that captions are hidden by default and appear when hovering over the thumbnail.

Before:

screen shot 2014-05-14 at 7 06 41 pm

After:

screen shot 2014-05-14 at 7 05 32 pm

@PavelTajdus
Contributor

Well, I have updated template, now its far better, but gallery dont respect settings from wordpress gallery. Got on page gallery with 4 columns, and with 3 columns. But 3clmn gallery look same as 4.

bug-gallery

@raamdev
Owner
raamdev commented May 19, 2014

Your screenshot shows three columns (the second row of photos), just like the settings show. So it looks like it's working to me. Am I missing something?

@PavelTajdus
Contributor

Yeah. 3 column gallery should be full width wide. As on wordpress 2014 theme is.

gallery

@PavelTajdus
Contributor

Well, U are theme developer, so its your decision, how will your theme show galleries.
But i think, that its good, when u use full width of page. So u can choose how many rows will have youre gallery, and by this u can have bigger thubnails. 1 column - big thumbnails - for portfolio etc. 4 column layout for many photos from vacation... etc etc.
I dont know if its even possible, coz im not coder. If not - I apologize :-)

@raamdev
Owner
raamdev commented May 19, 2014

@Tajdik Oh, it's definitely possible. And I agree it should take up the whole width when it's only 3 columns.

I will open a new issue for this and get it fixed for the next release. Thank you! :)

@raamdev
Owner
raamdev commented May 19, 2014

@Tajdik Actually, I just realized this is not a bug. In fact, the Independent Publisher theme and the TwentyFourteen theme behave exactly the same. The difference is that the TwentyFourteen theme has a smaller post width (534px) when compared to the Independent Publisher theme (700px).

The maximize size of the thumbnails (in both TwentyFourteen and Independent Publisher) is 150px.

If you resize the browser window when testing the multiple gallery columns on Independent Publisher, you'll see the same effect as you have on TwentyForteen:

screen shot 2014-05-19 at 6 21 10 pm

You can change the default thumbnail size from 150px to something bigger if you'd like:

screen shot 2014-05-19 at 6 27 08 pm

@PavelTajdus
Contributor

Oh, sorry. My bad. I changed the thumbnail size and reuploaded the images, and now it works great.
Thanx a lot for your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment