New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WordPress Editor style for image captions #103

Closed
saddington opened this Issue May 18, 2014 · 7 comments

Comments

Projects
None yet
2 participants
@saddington
Contributor

saddington commented May 18, 2014

ss 2014-05-17 at 8 46 17 pm

As you can see it's not super-pretty nor styled well. Superficial, but worth noting since you do have some editor styling (like the quotes).

ss 2014-05-17 at 8 47 35 pm

@raamdev

This comment has been minimized.

Owner

raamdev commented May 18, 2014

Can you paste the plaintext code from the editor for the captions you're referring to?

@saddington

This comment has been minimized.

Contributor

saddington commented May 18, 2014

I'm just saying that when you add captions to an image it doesn't look very pretty (as per the image).

See video here: http://d.john.do/fjJt

Code here: http://d.john.do/IOzN

@raamdev

This comment has been minimized.

Owner

raamdev commented May 18, 2014

Thanks for the video! Do you have a screenshot or example site with a "pretty" caption?

@saddington

This comment has been minimized.

Contributor

saddington commented May 18, 2014

well, a great example is just the captions in the editor for twenty twelve theme and the rest of the yearly-released themes.

@raamdev

This comment has been minimized.

Owner

raamdev commented May 19, 2014

Ah, I see now.

Editor style for image caption in Independent Publisher:

screen shot 2014-05-19 at 2 34 05 pm

Editor style for image caption in TwentyFourteen:

screen shot 2014-05-19 at 2 33 56 pm


I agree this should be fixed. @saddington Thanks so much for point this out. :) I'll add this as an enhancement and get it fixed before the next release.

@raamdev raamdev added this to the Next Release milestone May 19, 2014

@raamdev raamdev added the enhancement label May 19, 2014

@raamdev raamdev changed the title from Captions styling to Editor image caption styling May 19, 2014

@raamdev raamdev changed the title from Editor image caption styling to WordPress Editor style for image captions May 19, 2014

@raamdev

This comment has been minimized.

Owner

raamdev commented Aug 22, 2014

Fixed. The visual editor style for images with a caption now looks like this, which very closely matches what it looks like when the post is published:

2014-08-22_13-18-49

@raamdev raamdev closed this Aug 22, 2014

@saddington

This comment has been minimized.

Contributor

saddington commented Aug 22, 2014

yey!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment