Front Page Shows Link Color In Summary Text #188

Closed
adamcroom opened this Issue Apr 14, 2015 · 18 comments

Projects

None yet

5 participants

@adamcroom

My website is http://adamcroom.com. The text of front page summaries is the link color instead of black like the demo content. I see the correct view in the "Customize" viewer but not once I push out the update.

cchloh-wyaezob0

And, just as a note, I've gone ahead and made my link color a grey for now but would like to use the default green!

@raamdev
Owner
raamdev commented Apr 15, 2015

When I "view source" on your site, I notice there are several sections of the auto-generated Theme Customizer CSS missing (Text Color, Link Color):

        <!--WordPress Theme Customizer CSS-->
        <style type="text/css">

            /* Background Color */

            .site { background-color:#ffffff; }

            /* Comment Form Background Color */


            /* Text Color */


            /* Link Color */

Can you try going into WordPress Dashboard → Appearance → Customize, expand the Colors panel, click Select Color* on each one, and then press Default?

2015-04-15_12-49-45

Once that's done, hit Save and then visit your site and see if that fixed the issue.

If that did not fix the issue, then I'm thinking you might have a WordPress plugin installed that is conflicting with the Independent Publisher theme in some way--disabling plugins one-by-one and retesting should uncover the culprit.

@adamcroom

Thanks for the advice. Unfortunately, I wasn't able to solve the issue. All colors have been reset and I even disabled all plugins. My last idea was to start with a fresh Wordpress install and then import blog posts and media (and I did install ANY plugins) but I still had the same issue.

Adam

screen shot 2015-04-15 at 1 20 55 pm

@concatenateNL

Hi Adam,

A re-install shouldn't be necessary. Even if there is not a pertinent
solution right away, you could add some custom css to overrule the
current layout.
This should do the trick:

div.entry-content a {
color: black;
}

That said, I also notice that in the live preview a Continue Reading
link is present, which you don't have in your live website.
In you live website the entire excerpt is a link, which explains the
layout you get.

Sorry for only giving a quick fix. I am not that well know with this theme.

Best regards,
Michael

adamcroom schreef op 15-4-2015 om 20:26:

Thanks for the advice. Unfortunately, I wasn't able to solve the
issue. All colors have been reset and I even disabled all plugins. My
last idea was to start with a fresh Wordpress install and then import
blog posts and media (and I did install ANY plugins) but I still had
the same issue.

Adam

screen shot 2015-04-15 at 1 20 55 pm
https://cloud.githubusercontent.com/assets/11494815/7166362/049ce4c4-e373-11e4-98d4-db37acfd916f.png


Reply to this email directly or view it on GitHub
#188 (comment).

@adamcroom

Michael—I’ve added that to the CSS. The only problem with it is that now the links inside my blog posts are also black.


Sent from Mailbox

On Wed, Apr 15, 2015 at 1:40 PM, concatenateNL notifications@github.com
wrote:

Hi Adam,
A re-install shouldn't be necessary. Even if there is not a pertinent
solution right away, you could add some custom css to overrule the
current layout.
This should do the trick:
div.entry-content a {
color: black;
}
That said, I also notice that in the live preview a Continue Reading
link is present, which you don't have in your live website.
In you live website the entire excerpt is a link, which explains the
layout you get.
Sorry for only giving a quick fix. I am not that well know with this theme.
Best regards,
Michael
adamcroom schreef op 15-4-2015 om 20:26:

Thanks for the advice. Unfortunately, I wasn't able to solve the
issue. All colors have been reset and I even disabled all plugins. My
last idea was to start with a fresh Wordpress install and then import
blog posts and media (and I did install ANY plugins) but I still had
the same issue.

Adam

screen shot 2015-04-15 at 1 20 55 pm
https://cloud.githubusercontent.com/assets/11494815/7166362/049ce4c4-e373-11e4-98d4-db37acfd916f.png


Reply to this email directly or view it on GitHub
#188 (comment).


Reply to this email directly or view it on GitHub:
#188 (comment)

@raamdev
Owner
raamdev commented Apr 15, 2015

@adamcroom Who are you using for a web host?

@adamcroom

Reclaim Hosting: http://reclaimhosting.com


Sent from Mailbox

On Wed, Apr 15, 2015 at 2:25 PM, Raam Dev notifications@github.com
wrote:

@adamcroom Who are you using for a web host?

Reply to this email directly or view it on GitHub:
#188 (comment)

@raamdev
Owner
raamdev commented Apr 15, 2015

@adamcroom I just tested the theme on two different hosts (WP Engine and LiquidWeb) and I haven't been able to reproduce this issue.

Any chance you could give me a temporary WordPress Dashboard admin account and access to the database (via phpMyAdmin)? If you have a test site with a clean install of WordPress where this is happening, I can use that to diagnose this further.

@adamcroom

@raamdev — sure thing. Whats the best way to get it to you privately?


Sent from Mailbox

On Wed, Apr 15, 2015 at 2:48 PM, Raam Dev notifications@github.com
wrote:

@adamcroom I just tested the theme on two different hosts (WP Engine and LiquidWeb) and I haven't been able to reproduce this issue.

Any chance you could give me a temporary WordPress Dashboard admin account and access to the database (via phpMyAdmin)? If you have a test site with a clean install of WordPress where this is happening, I can use that to diagnose this further.

Reply to this email directly or view it on GitHub:
#188 (comment)

@raamdev
Owner
raamdev commented Apr 15, 2015

Email raam @ [my GitHub username] .com

@concatenateNL

Sorry about that. It was a quick fix and I couldn't reproduce it myself.
But I see Raam is on top of it, as always.

Good luck.

adamcroom schreef op 15-4-2015 om 21:15:

Michael—I’ve added that to the CSS. The only problem with it is that
now the links inside my blog posts are also black.


Sent from Mailbox

On Wed, Apr 15, 2015 at 1:40 PM, concatenateNL notifications@github.com
wrote:

Hi Adam,
A re-install shouldn't be necessary. Even if there is not a pertinent
solution right away, you could add some custom css to overrule the
current layout.
This should do the trick:
div.entry-content a {
color: black;
}
That said, I also notice that in the live preview a Continue Reading
link is present, which you don't have in your live website.
In you live website the entire excerpt is a link, which explains the
layout you get.
Sorry for only giving a quick fix. I am not that well know with this
theme.
Best regards,
Michael
adamcroom schreef op 15-4-2015 om 20:26:

Thanks for the advice. Unfortunately, I wasn't able to solve the
issue. All colors have been reset and I even disabled all plugins. My
last idea was to start with a fresh Wordpress install and then import
blog posts and media (and I did install ANY plugins) but I still had
the same issue.

Adam

screen shot 2015-04-15 at 1 20 55 pm

https://cloud.githubusercontent.com/assets/11494815/7166362/049ce4c4-e373-11e4-98d4-db37acfd916f.png


Reply to this email directly or view it on GitHub

#188 (comment).


Reply to this email directly or view it on GitHub:

#188 (comment)


Reply to this email directly or view it on GitHub
#188 (comment).

Met vriendelijke groet,

Michael Albers
Concatenate
Stationsweg 47, 2131 XC, Hoofddorp
T: +31 23 56 10 273 - M: +31 62 88 38 421 - E: info@concatenate.nl
mailto:info@concatenate.nl - W: http://www.concatenate.nl/
http://www.concatenate.nl.nl/ - L: http://www.linkedin.com/in/concatenate
KvK : 24329371 - AV: www.concatenate.nl/algemene_voorwaarden/
http://www.concatenate.nl/algemene_voorwaarden/

@raamdev
Owner
raamdev commented Apr 15, 2015

@concatenateNL Thanks for helping out! :-)

@adamcroom

@raamdev email sent!

@Lamakopf

@raamdev Hi, I have the exact same problem with your theme (http://www.lamakopf.de) and I was wondering if you found the mistake?
I'm not very good in coding and so I didn't try anything yet.

bildschirmfoto 2015-09-29 um 16 10 17

@jan-vandenberg

What I did was: on line 1093 of functions.php I deleted the "!" (I know it's an ugly fix but it works for me).

@Lamakopf

@jan-vandenberg Thank you, it worked perfectly!

@raamdev
Owner
raamdev commented Nov 1, 2015

I believe that I have finally figured out what was causing this problem:

If you customize the Link Color without ever touching the Text Color, the Text Color never actually gets set and then this line returns false, which means the theme never overrides the newly customized Link Color.

Changing this line to the following should fix this bug:

$default_mod_value = ($mod_name === 'text_color' ? '#000000' : '');
$mod = get_theme_mod( $mod_name, $default_mod_value );
@raamdev raamdev removed the needs research label Nov 1, 2015
@raamdev raamdev added this to the Next Release milestone Nov 1, 2015
@raamdev
Owner
raamdev commented Nov 1, 2015

Next Release Changelog:

  • Bug Fix: Fixed a bug where the post excerpts on the home page would use the Link Color instead of the Text Color. Props @adamcroom and Jakub Kapusnak. See Issue #188.
@raamdev raamdev closed this Nov 1, 2015
@adamcroom

Thanks for this fix @raamdev! Much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment