Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microformats 2 Markup #221

Closed
dshanske opened this issue May 10, 2016 · 7 comments
Closed

Microformats 2 Markup #221

dshanske opened this issue May 10, 2016 · 7 comments
Labels
Milestone

Comments

@dshanske
Copy link
Contributor

@dshanske dshanske commented May 10, 2016

I can do this as a PR if you'd like. But if you are amenable, I think I can help get your theme microformats 2 compliant as well.

However, your CSS currently styles several of the classic microformats classes.

@raamdev
Copy link
Owner

@raamdev raamdev commented May 10, 2016

@dshanske I'd love to see a PR for this! If you tell me which CSS creates problems and why, I can help fix that.

@raamdev raamdev added the enhancement label May 10, 2016
@raamdev raamdev added this to the Next Release milestone May 10, 2016
@dshanske
Copy link
Contributor Author

@dshanske dshanske commented May 10, 2016

They aren't exactly problems per se. It is just a recommended practice because markup should be separate from styling.

But I'll see what I can do with a fork.

@raamdev
Copy link
Owner

@raamdev raamdev commented May 14, 2016

@dshanske Any progress on this? I'm hoping to do a new release soon (the first in over a year and a half), and would love to get microformats 2 added in.

@dshanske
Copy link
Contributor Author

@dshanske dshanske commented May 14, 2016

Let me spend some time on it this weekend and see if I can make some simple improvements.

@raamdev
Copy link
Owner

@raamdev raamdev commented May 14, 2016

@dshanske Great! Thank you. In that case, I'll hold off on doing the release until at least sometime next week.

@dshanske
Copy link
Contributor Author

@dshanske dshanske commented May 14, 2016

I have much of the code already in mind. Just have to figure out some things.

@raamdev
Copy link
Owner

@raamdev raamdev commented May 20, 2016

Next Release Changelog:

  • Enhancement: Added Microformats 2 markup. This includes a change to the classes applied to the content DIV on listings of posts: If an excerpt is being shown, the classes are entry-summary e-summary; if the full content is being shown, entry-content e-content is used. If you have a Child Theme with custom CSS targeting entry-content, you may need to update it to include entry-summary. Props @dshanske. See Issue #221.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.