Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor adjustment of wp-pagenavi css needed #229

Closed
johlym opened this issue May 28, 2016 · 6 comments
Closed

Minor adjustment of wp-pagenavi css needed #229

johlym opened this issue May 28, 2016 · 6 comments
Labels
bug
Milestone

Comments

@johlym
Copy link
Contributor

@johlym johlym commented May 28, 2016

The first span for wp-pagenavi has a bottom padding that's a pixel too thick:

screen shot 2016-05-27 at 7 48 05 pm

#228 should fix this. Tested in Safari and Chrome.

screen shot 2016-05-27 at 7 49 06 pm

@raamdev
Copy link
Owner

@raamdev raamdev commented Jun 2, 2016

@johlym Hmm, where are you seeing that the bottom padding is a pixel too thick? I'm not seeing that on either the main blog listing or on the single post page (using Chrome 50 on OS X):

2016-06-02_09-21-18


2016-06-02_09-21-06

@raamdev
Copy link
Owner

@raamdev raamdev commented Jul 5, 2016

@johlym Were you testing this on a Mac, Windows, or Linux?

@vskjefst
Copy link
Contributor

@vskjefst vskjefst commented Jul 16, 2016

I've seen this issue as well, on Firefox (most recent version), running on Windows 10.

@raamdev
Copy link
Owner

@raamdev raamdev commented Jul 16, 2016

@vskjefst Do you mean specifically using WP-PageNavi + Independent Publisher? Or are you referring to having seen it with other plugins?

@vskjefst
Copy link
Contributor

@vskjefst vskjefst commented Jul 16, 2016

With WP-PageNavi + Independent Publisher. I'm seeing exactly what @johlym is describing. It doesn't happen everywhere, though. On a page listing posts with a specific tag, for instance, The pagenavi looks good in the summary box on the top of the page, but not on the bottom of the page.

raamdev added a commit that referenced this issue Jul 16, 2016
Adjust padding to fix bottom border of WP-PageNavi span in Firefox

#229
@raamdev raamdev added bug and removed cannot reproduce labels Jul 16, 2016
@raamdev raamdev added this to the Next Release milestone Jul 16, 2016
@raamdev
Copy link
Owner

@raamdev raamdev commented Jul 16, 2016

@vskjefst Thank you! That's exactly what I needed to be able to reproduce the issue: bottom of a tag archive.

I've reproduced the issue and confirmed that #228 fixes the issue, which has been merged now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants