/independent-publisher

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aria-label in comment "Reply to" links mentions author name twice #252

Closed
raamdev opened this Issue Nov 16, 2016 · 0 comments

Comments

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
  v1.8
1 participant
@raamdev
@raamdev
Owner

raamdev commented Nov 16, 2016

The "Reply to" link in comments that includes the author name has a bug in the aria-label associated with that link:

2016-11-15_20-15-56

<a href[...] aria-label="Reply to Raam to Raam Dev">Reply to Raam</a>

As you can see the aria-label says Reply to Raam to Raam Dev, mentioning the author name twice. This is rather confusing for anyone with a screen reader. It should just say Reply to Raam, like the link itself.

@raamdev raamdev added the bug label Nov 16, 2016

@raamdev raamdev added this to the Next Release milestone Nov 16, 2016

@raamdev raamdev changed the title from aria-label in comment "Reply to" links mentioned author name twice to aria-label in comment "Reply to" links mentions author name twice Nov 16, 2016

raamdev added a commit that referenced this issue Nov 16, 2016

@raamdev
Fix bug where aria-label in comment "Reply to" link contains duplicate 
See #252
Verified
This commit was signed with a verified signature.
@raamdev raamdev Raam Dev
GPG key ID: 0EB5BB6BD84199EA Learn about signing commits
824710f

@raamdev raamdev closed this Nov 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment