Feature Request: Fancy loading bars like Medium #35

Closed
vividvilla opened this Issue Dec 15, 2013 · 10 comments

Projects

None yet

3 participants

@vividvilla

How about adding fancy load bars like in medium using nprogress.js - https://github.com/rstacruz/nprogress

@raamdev
Owner
raamdev commented Dec 16, 2013

Yes! I love this idea. I'll accept this feature request and work this in soon.

@tlongren
Contributor
tlongren commented Apr 7, 2014

Any objections to pace?
http://github.hubspot.com/pace/docs/welcome/

Either way, I'll tackle this feature request.

@raamdev
Owner
raamdev commented Apr 7, 2014

Nope. No objection. My heart isn't set on anything. It just needs to be GPL and I'd prefer something as light as possible, of course. :)

Thanks so much for tackling this!

@raamdev
Owner
raamdev commented Apr 7, 2014

Regarding GPL-compatibility: This is required because WordPress requires it for hosting the theme in the WordPress.org Theme Repository:

Themes are required to be 100% GPL-licensed, or use a GPL-compatible license. This includes all PHP, HTML, CSS, images, fonts, icons, and everything else. All of the theme must be GPL-Compatible.

http://make.wordpress.org/themes/guidelines/guidelines-license-theme-name-credit-links-up-sell-themes/

@tlongren
Contributor
tlongren commented Apr 7, 2014

@raamdev, will nprogress load by default and be always-on? Or does there need to be enable/disable ability?

Also, assign this to me?

@raamdev raamdev assigned raamdev and unassigned raamdev Apr 8, 2014
@raamdev
Owner
raamdev commented Apr 8, 2014

will nprogress load by default and be always-on? Or does there need to be enable/disable ability?

I'd definitely like to make this optional, off by default. (Since the theme has already been released, I don't want to release an update that suddenly toggles a new feature on without the user choosing to do so first.) It can probably just be a checkbox in the theme customizer, under General Options. (See inc/customizer.php and functions.php for the functions that are used to check if an option is on/off, e.g., independent_publisher_show_post_word_count()).

Also, assign this to me?

I would expect that I could assign it to you, especially since you're already listed as a collaborator on the project, but for some reason the assign list only lets me assign it to myself...

screen shot 2014-04-07 at 8 36 22 pm

screen shot 2014-04-07 at 8 36 17 pm

@raamdev
Owner
raamdev commented Apr 8, 2014

BTW, the MIT License is compatible with GPL, so nprogress should be good to use in the theme.

@tlongren
Contributor
tlongren commented Apr 8, 2014

@raamdev need feedback:
http://codepen.io/tlongren/pen/xDEnz

Bar is intentionally chubby to make it easier to see. :)

@tlongren tlongren referenced this issue Apr 8, 2014
Merged

Add nprogress #78

@tlongren
Contributor
tlongren commented Apr 8, 2014

Pull Request #78 has been sent!

Close this out and move discussion there?

@raamdev
Owner
raamdev commented Apr 8, 2014

@tlongren Thanks so much!

(Reiterating what I commented on the Pull Request.)

I reviewed the Pull Request, made a few changes, and then merged it into master. This will go out with the next release. :)

I'll close this issue when I make the next release.

@raamdev raamdev added a commit that closed this issue Apr 10, 2014
@raamdev Releasing v1.4
* Fixes #82
* Fixes #75
* Fixes #72
* Fixes #35
ce5fda2
@raamdev raamdev closed this in ce5fda2 Apr 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment