Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Title + caption to appear on top of the full cover image #47

Closed
sergioschuler opened this issue Jan 3, 2014 · 18 comments
Milestone

Comments

@sergioschuler
Copy link

Like this:

screenshot on 1 2 2014 at 10 07 25 pm

@raamdev
Copy link
Owner

raamdev commented Jan 4, 2014

This would be nice. If anyone wants to submit a pull request for this, I'd love to take a look at adding this in as a feature.

@bonedoc
Copy link

bonedoc commented Apr 1, 2014

Liked this feature too. Easier for people to navigate back to home screen. :) Thanks.

@tlongren
Copy link
Contributor

@raamdev I could tackle this.

@bonedoc, how would adding title & caption on full cover image make it easier to get back to the home screen? Just trying to understand what you're envisioning before I start this.

@raamdev
Copy link
Owner

raamdev commented Apr 11, 2014

@tlongren That would be awesome. :) One thing that's going to make this challenging, I believe, is the fact that the post cover exists outside the main loop, in header.php.

Actually, I just looked at the code and independent_publisher_full_width_featured_image() starts a loop to get the featured image for the post, so you can probably tap into that to add the post title (maybe improve independent_publisher_full_width_featured_image() to accept an optional parameter that adds the post title on top of the image).

If you want to add subtitle support (like in the screenshot), the best way to do that is probably going to be through a Custom Field attached to the post (e.g., something like independent_publisher_post_cover_subtitle with its value set to the subtitle that you want to appear under the title). Then you can just check for that custom field using get_post_meta() when you're adding the title.

In fact, I suggest toggling post title on the cover image functionality using a Custom Field as well. Any post that has the Custom Field independent_publisher_post_cover_title with a value of true added, and also has a full-width featured image, will have the title appear on top of the post cover.

@bonedoc, how would adding title & caption on full cover image make it easier to get back to the home screen? Just trying to understand what you're envisioning before I start this.

I think he's probably referring to the little icon in the top-left of the screenshot, but that feature already exists.

@tlongren
Copy link
Contributor

Sounds awesome. Gimme a bit, got a few projects I'm finishing up in the next few weeks. Time's pretty tight at the moment.

I'll test better before this PR, too, heh.

@raamdev
Copy link
Owner

raamdev commented Apr 13, 2014

Sounds great! No rush. I think I'm done with updates to the theme for awhile.

@joshkerr
Copy link

Why are you done with updates for a while? You were doing so awesome!

Could you add an option to automatically make featured images go full width instead of making me have to update then set the option then update again?

@raamdev
Copy link
Owner

raamdev commented Apr 13, 2014

Well, I don't want to break child themes that already exist in the wild, so I've got to be careful about adding features or changing things.

That said, I like the idea for an option to automatically apply the full-width featured image. Can you open a feature request (Issue) for that on GitHub?

@descubraomundo
Copy link
Contributor

I really like you theme, is this is definitely something I would love to see on it...
Did you guys make any progress in this feature?

@raamdev
Copy link
Owner

raamdev commented Jul 25, 2014

@descubraomundo No progress yet. I work on this project in my spare time and I haven't had much spare time lately. Feel free to submit a Pull Request if you'd like to try working on it yourself. :)

descubraomundo pushed a commit to descubraomundo/independent-publisher that referenced this issue Jul 29, 2014
@raamdev raamdev added this to the Next Release milestone Aug 13, 2014
@raamdev
Copy link
Owner

raamdev commented Aug 13, 2014

Woohoo! Thanks to work by @descubraomundo, this feature will be coming with the next release of Independent Publisher! Here's a screenshot of the new "Overlay Post Title on Post Cover" option:

2014-08-12_15-32-08


The post title itself fades out as you scroll down. Also, the post cover uses a DIV with the featured image set as the background, so if you want the post cover to take up 100% of the browser viewport (like Medium.com), you can easly do so by adding the following CSS to a child theme:

.single.post-cover-overlay-post-title .post-cover-title-image { height: 100vh !important; }

The default style will have the post cover take up 75% of the browser viewport when the "Overlay Post Title on Post Cover" option is enabled.

There are no changes to the behavior of the existing "Featured Image as Post Cover" option.

Enabling this option on a per-post basis

It will also be possible to enable the "Overlay Post Title on Post Cover" option on a per-post basis, by creating a Custom Field on the post with the key post_cover_overlay_post_title and the value true.

@raamdev raamdev closed this as completed Aug 13, 2014
@descubraomundo
Copy link
Contributor

Really Happy I could help with this.

I changed a little bit on my child theme to look more like Medium.com, it's in portuguese, but you can checkout at:
http://www.descubraomundo.com/blog/top-5-roteiro-na-europa-para-intercambistas-cervejeiros/
top 5 roteiro na europa para intercambistas cervejeiros - blog descubra o mundo 1

Also with a little bit more of CSS and a WordPress plugin to add images to taxonomies, you can create the same post effect for your categories page:
http://www.descubraomundo.com/blog/dicas/
I'm using the Sideways8 Simple Taxonomy Images plugin for that:
http://sideways8.com/plugins/s8-simple-taxonomy-images/

I'm also using another project called FluidBox to make the images zoom in like at Medium, if you want to add as something that is nice to use with the template. The project is:
http://terrymun.github.io/Fluidbox/
And there's also a WordPress plugin for that:
https://wordpress.org/plugins/fluidbox/

@raamdev
Copy link
Owner

raamdev commented Aug 15, 2014

@descubraomundo Thank you for sharing the plugins you're using on your site! I'm sure others who want those same features will find that information very helpful. :) Your site looks amazing!

@sergioschuler
Copy link
Author

When will it be updated on Wordpress.org? :D

@sergiojota https://twitter.com/sergiojota
sergioschuler.com

On Thu, Aug 14, 2014 at 11:49 PM, Raam Dev notifications@github.com wrote:

@descubraomundo https://github.com/descubraomundo Thank you for sharing
the plugins you're using on your site! I'm sure others who want those same
features will find that information very helpful. :) Your site looks
amazing!


Reply to this email directly or view it on GitHub
#47 (comment)
.

@raamdev
Copy link
Owner

raamdev commented Aug 18, 2014

When will it be updated on Wordpress.org? :D

Soon. :) I'll try to work on getting a release out this week.

@sergioschuler
Copy link
Author

Weird, when I enable the option, my post cover image vanishes
image

@raamdev
Copy link
Owner

raamdev commented Sep 6, 2014

@sergioschuler Hmm, that IS weird. Are you using a Child Theme? Might there be something you've customized that is affecting the option?

@sergioschuler
Copy link
Author

Oh, damn, yeah, that must be it! I will see what is wrong with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants