Customizer Colors: Changing 'Secondary Meta Text Color' affects 'Continue Reading' link color (Live Preview) #66

Closed
raamdev opened this Issue Mar 13, 2014 · 1 comment

Projects

None yet

1 participant

@raamdev
Owner
raamdev commented Mar 13, 2014

(Note: This issue only affects the Live Preview and saving a custom color for Secondary Meta Text Color doesn't affect the color of the "Continue Reading" when you press Save Changes.)

When you change the Secondary Meta Text Color in the Theme Customizer, the Live Preview incorrectly modifies the link color of the "Continue Reading →" link (which appears when using the "Generate One-Sentence Excerpts" option):

screen shot 2014-03-13 at 5 58 17 pm

screen shot 2014-03-13 at 5 58 52 pm

This is due to the fact that the "Continue Reading" link is inside the entry-meta div and the Customizer JavaScript (inc/theme-customizer.js) that does the Live Preview modifies .entry-meta a:

$('.entry-meta a').css('color', newval);

The solution is to move the enhanced-excerpt-read-more div that contains the "Continue Reading" link outside the entry-meta div (see independent_publisher_continue_reading_link() in content.php).

This will require a bit of work to make sure the styles work properly for the Continue Reading link. This is not a priority issue since it only affects the Live Preview.

@raamdev raamdev added the bug label Mar 13, 2014
@raamdev
Owner
raamdev commented Mar 29, 2014

Fixed in development copy. Will go out with next release.

@raamdev raamdev closed this Mar 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment