New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show thumbnail on gallery post format #178

Merged
merged 2 commits into from Feb 23, 2015

Conversation

Projects
None yet
2 participants
@joch
Contributor

joch commented Feb 21, 2015

Not sure what your stance on this is, but I at least would find it terribly useful to display thumbnails for gallery posts in addition to standard posts.

If not by default, then perhaps it could be a setting?

@raamdev

This comment has been minimized.

Owner

raamdev commented Feb 21, 2015

@joch Thanks for the Pull Request! :-) I have nothing wrong with this and would be happy to merge it.

Could you just update the comment above that line to read:

/* Only show featured image for Standard post and gallery post formats */

If you can push that change to this PR, I'll merge it right in and have this go out with the next theme update.

@raamdev raamdev added the enhancement label Feb 21, 2015

@raamdev raamdev added this to the Next Release milestone Feb 21, 2015

@joch

This comment has been minimized.

Contributor

joch commented Feb 22, 2015

@raamdev Right thanks, missed changing the comment! Done now though. :-)

raamdev added a commit that referenced this pull request Feb 23, 2015

Merge pull request #178 from joch/master
Show Featured Image for in Archive views for Gallery Post Format

@raamdev raamdev merged commit 0e5fcd3 into raamdev:master Feb 23, 2015

@raamdev

This comment has been minimized.

Owner

raamdev commented Feb 23, 2015

@joch Merged! Thank you for contributing. :-) This will go out with the next release:

  • Enhancement: Posts with a Gallery Post Format that include a Featured Image now display the Featured Image in Archive views (home page, date-based archives, category/tag-based archives, etc.). Props to @joch. See #178.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment