Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upConversation
raamdev
reviewed
Jul 16, 2016
| @@ -354,11 +365,12 @@ function independent_publisher_author_comment_reply_link( $link, $args, $comment | ||
| } | ||
| // If the user provided more than a first name, use only first name | ||
| if ( strpos( $author, ' ' ) ) { | ||
| $independent_publisher_general_options = get_option( 'independent_publisher_general_options' ); |
This comment has been minimized.
This comment has been minimized.
raamdev
Jul 16, 2016
Owner
This line can be removed; $independent_publisher_general_options is not used here.
raamdev
reviewed
Jul 16, 2016
| $wp_customize->add_control( | ||
| 'show_comment_authors_full_name_in_reply_link', array( | ||
| 'settings' => 'independent_publisher_general_options[show_comment_authors_full_name_in_reply_link]', | ||
| 'label' => __( 'Show comment author\'s full name in reply-link', 'independent-publisher' ), |
This comment has been minimized.
This comment has been minimized.
raamdev
Jul 16, 2016
Owner
I suggest changing the label here to "Show Full Name in Comment Reply-to":
That will fit better in the Customizer than what you have now:
raamdev
reviewed
Jul 16, 2016
| // Show comment author's full name in reply-link | ||
| $wp_customize->add_setting( | ||
| 'independent_publisher_general_options[show_comment_authors_full_name_in_reply_link]', array( |
This comment has been minimized.
This comment has been minimized.
raamdev
Jul 16, 2016
Owner
I suggest changing the option key to show_full_name_comment_reply_to (this will need to be updated anywhere this key is used).
This comment has been minimized.
This comment has been minimized.
|
@vskjefst Thanks so much for the Pull Request! I tested this out and it works great. :-) I left you a few comments above with a few change requests.
There's no need to worry about that—I'll regenerate the translation POT file right before I do the next release. |
This comment has been minimized.
This comment has been minimized.
|
@raamdev The necessary changes are now pushed to the PR branch. |
raamdev
reviewed
Jul 16, 2016
| @@ -333,9 +333,20 @@ function independent_publisher_comment_count( $count ) { | ||
| } | ||
| } | ||
| if ( ! function_exists( 'independent_publisher_show_comment_authors_full_name_in_reply_link' ) ): |
This comment has been minimized.
This comment has been minimized.
raamdev
Jul 16, 2016
Owner
@vskjefst Could you also rename this function to independent_publisher_show_full_name_comment_reply_to?
This comment has been minimized.
This comment has been minimized.
|
@raamdev yup, done. |
raamdev
merged commit ef37fab
into
raamdev:master
Jul 19, 2016
This comment has been minimized.
This comment has been minimized.
|
Woohoo! Merged. Thank you! |
This comment has been minimized.
This comment has been minimized.
|
Posting a screenshot of this new option for future reference:
|
vskjefst commentedJul 16, 2016
Not sure how you usually handle new strings that needs to be translated?