Added option to display comment author's full name in reply link. #237
Conversation
| @@ -354,11 +365,12 @@ function independent_publisher_author_comment_reply_link( $link, $args, $comment | |||
| } | |||
|
|
|||
| // If the user provided more than a first name, use only first name | |||
| if ( strpos( $author, ' ' ) ) { | |||
| $independent_publisher_general_options = get_option( 'independent_publisher_general_options' ); | |||
raamdev
Jul 16, 2016
Owner
This line can be removed; $independent_publisher_general_options is not used here.
This line can be removed; $independent_publisher_general_options is not used here.
| $wp_customize->add_control( | ||
| 'show_comment_authors_full_name_in_reply_link', array( | ||
| 'settings' => 'independent_publisher_general_options[show_comment_authors_full_name_in_reply_link]', | ||
| 'label' => __( 'Show comment author\'s full name in reply-link', 'independent-publisher' ), |
raamdev
Jul 16, 2016
Owner
I suggest changing the label here to "Show Full Name in Comment Reply-to":
That will fit better in the Customizer than what you have now:
I suggest changing the label here to "Show Full Name in Comment Reply-to":
That will fit better in the Customizer than what you have now:
|
|
||
| // Show comment author's full name in reply-link | ||
| $wp_customize->add_setting( | ||
| 'independent_publisher_general_options[show_comment_authors_full_name_in_reply_link]', array( |
raamdev
Jul 16, 2016
Owner
I suggest changing the option key to show_full_name_comment_reply_to (this will need to be updated anywhere this key is used).
I suggest changing the option key to show_full_name_comment_reply_to (this will need to be updated anywhere this key is used).
|
@vskjefst Thanks so much for the Pull Request! I tested this out and it works great. :-) I left you a few comments above with a few change requests.
There's no need to worry about that—I'll regenerate the translation POT file right before I do the next release. |
…name in reply-to links.
|
@raamdev The necessary changes are now pushed to the PR branch. |
| @@ -333,9 +333,20 @@ function independent_publisher_comment_count( $count ) { | |||
| } | |||
| } | |||
|
|
|||
| if ( ! function_exists( 'independent_publisher_show_comment_authors_full_name_in_reply_link' ) ): | |||
raamdev
Jul 16, 2016
Owner
@vskjefst Could you also rename this function to independent_publisher_show_full_name_comment_reply_to?
@vskjefst Could you also rename this function to independent_publisher_show_full_name_comment_reply_to?
…uld be displayed or not.
|
@raamdev yup, done. |
|
Woohoo! Merged. Thank you! |
|
Posting a screenshot of this new option for future reference:
|
Not sure how you usually handle new strings that needs to be translated?