New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed handling of default colors to make sure they are always used… #240

Merged
merged 2 commits into from Jul 28, 2016

Conversation

Projects
None yet
2 participants
@vskjefst
Contributor

vskjefst commented Jul 19, 2016

… when no custom color has been defined.

This probably means that there is no longer need for these colors to be defined in style.css since they are always overridden.

'link_color' => '#57ad68',
'header_text_color' => '#333332',
'primary_meta_text_color' => '#929292',
'secondary_meta_text_color' => 'b3b3b1'

This comment has been minimized.

@raamdev

raamdev Jul 28, 2016

Owner

This line is missing a #.

@raamdev

This comment has been minimized.

Owner

raamdev commented Jul 28, 2016

@vskjefst Other than my above note, this PR looks great. It's definitely a much better way of handling that code. :-) I also went back and reviewed #188, which was a bug fixed by this line that your PR removes, however in your PR you're passing the default color to get_theme_mod() no matter what, so we shouldn't have a problem there.

Once you fix the above note, I'll merge this in. Thanks!

@vskjefst

This comment has been minimized.

Contributor

vskjefst commented Jul 28, 2016

@raamdev well, that's embarrassing. The missing # is there now. I'm pretty sure #188 is handled by the new code.

@raamdev raamdev merged commit 5695681 into raamdev:master Jul 28, 2016

@raamdev

This comment has been minimized.

Owner

raamdev commented Jul 28, 2016

Next Release Changelog:

@vskjefst vskjefst deleted the vskjefst:feature/default-colors-handling branch Jul 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment