Changed handling of default colors to make sure they are always used… #240
Conversation
… when no custom color has been defined.
inc/customizer.php
Outdated
| 'link_color' => '#57ad68', | ||
| 'header_text_color' => '#333332', | ||
| 'primary_meta_text_color' => '#929292', | ||
| 'secondary_meta_text_color' => 'b3b3b1' |
raamdev
Jul 28, 2016
Owner
This line is missing a #.
This line is missing a #.
|
@vskjefst Other than my above note, this PR looks great. It's definitely a much better way of handling that code. :-) I also went back and reviewed #188, which was a bug fixed by this line that your PR removes, however in your PR you're passing the default color to Once you fix the above note, I'll merge this in. Thanks! |
|
Next Release Changelog:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
… when no custom color has been defined.
This probably means that there is no longer need for these colors to be defined in style.css since they are always overridden.