Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: This commit creates a github actions file which will execute build #8

Merged
merged 3 commits into from May 2, 2023

Conversation

poetaster
Copy link
Contributor

and release when a tag beginning with v is commited. It uses @CODeRUS docker images.

…ld and release when a tag beginning with v is commited
… the formula input on the right. Output is shifted down a line to accomodate. This allows for a quick lookup which doing calculations
@poetaster
Copy link
Contributor Author

The rest of my work is in other branches.

@rabauke
Copy link
Owner

rabauke commented May 1, 2023

The addition of a git workflow is highly appreciated.

Regarding the UI changes, though, I think they do not comply with the Sailfish OS design principles, which favours gestures over buttons. Furthermore, the added help-button covers too much screen estate and appears distracting to me.

Nevertheless, your UI changes address an actual shortcoming of the current UI: The documentation for the available mathematical functions is not easy to access. Users might not expect to find this under the "About Babbage".

As an alternative to your UI changes I would suggest to add an additional PushUpMenu with a single menu item to open the "List of function". (One might consider, adding this menu item to the existing PullDownMenu, though I think it is good practice to keep the number of menu items per menu small.) The push-up-menu approach would be more consistent with the Sailfish OS design principles.

@poetaster
Copy link
Contributor Author

As an alternative to your UI changes I would suggest to add an additional PushUpMenu with a single menu item to open the "List of function". (One might consider, adding this menu item to the existing PullDownMenu, though I think it is good practice to keep the number of menu items per menu small.) The push-up-menu approach would be more consistent with the Sailfish OS design principles.

That's a reasonable suggestion. For the Exprtk interfaces, however, I would prefer to have the short cut handy since it it, simply, reasonable to hit the button than invoke a gesture. It's much more efficient. I have, on my https://github.com/poetaster/harbour-babbage/tree/document branch also implemented copy from your FunctionDoc type, but it's a hack. In my documentation, I'm using a listivew with context menu which is cleaner, but I was unable to make work for FunctionDoc.

I'm going to PR the document branch now to see what you think. I suspect there will probably be too many diverging interests, philosophical disputes, but babbage was all we had to date. Thanks!

@poetaster
Copy link
Contributor Author

Just a note, I've tested the github action (using: git tag v0.19, git push origin --tags) and it's clean. tested aarch64 and arm.
https://github.com/poetaster/harbour-babbage/releases if you wish you can see the exprtk work from that install.

@rabauke rabauke self-assigned this May 2, 2023
Help button clutters the UI. Buttons should be avoided for user interaction as Sailfish OS provides several platform-style alternatives based on gestures.
@rabauke rabauke merged commit 12d9b21 into rabauke:master May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants